This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
This is the DMP related part of #1702
pepyakin
added
A0-please_review
coriolinus
approved these changes
Oct 29, 2020
| /// - `B`: is the relay-chain block number in which a message was appended. | ||
| /// - `H(M)`: is the hash of the message being appended. | ||
| DownwardMessageQueueHeads: map ParaId => Option<Hash>; | ||
| DownwardMessageQueueHeads: map ParaId => Hash; |
Contributor
There was a problem hiding this comment.
So, for a p: ParaId, instead of mapping DownwardMessageQueueHeads[p] == None, you just exclude p from DownwardMessageQueueHeads?
Contributor
Author
There was a problem hiding this comment.
if by exclude you mean call remove on it, then yeah!
polkadot/runtime/parachains/src/router/dmp.rs
Lines 34 to 35 in d34585d
Contributor
Author
|
bot merge |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow ups for the recently merged #1859, namely,
Split from the #1679